feat/draft: 드래프트 관련 수정 - #82
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough인증 사용자 컨텍스트를 Draft 참가자 조회 흐름에 도입했다. 컨트롤러와 서비스 메서드 시그니처에 사용자 정보를 추가하고, Participant 엔티티의 DTO 변환 로직이 사용자 이메일 기반 userFlag를 설정하도록 변경되었다. 또한 ElementType DTO에 squadMinPlay/squadMaxPlay 필드가 추가되고 매핑이 확장되었다. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as Authenticated User
participant C as DraftController
participant S as DraftService
participant P as Participant (entity)
U->>C: GET /api/draft/{draftId}/participants (AuthenticationPrincipal)
C->>S: getParticipantsByDraftId(draftId, userEmail)
S->>P: toDtoList(participants, userEmail)
P-->>S: List<DraftParticipant> (userFlag set)
S-->>C: List<DraftParticipant>
C-->>U: 200 OK + JSON
note over P,S: userEmail 일치 시 userFlag=true
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (6)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit